This repository was archived by the owner on Jul 29, 2025. It is now read-only.
Repository navigation
React Native "native" SDK - #4
Merged
Merged
Conversation
weyert
reviewed
Jul 15, 2022
weyert
reviewed
Jul 15, 2022
weyert
left a comment
There was a problem hiding this comment.
Looking great! I have might some suggestions that I saw while having a quick look :)
You could use the Or depending on the build tools you could also use something like https://github.com/google/semantic-release-replace-plugin |
Fixed anonymous id calls
fix: Remove decide endpoint timer
fix: Limit autocapture to only include specific props
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do I want to actually release?
/examples/example-expo> An example Expo app showing how Posthog can be used without any native rebuilding/posthog-core> The "core" package containing all non-platform specific code (interface, queueing logic etc.)/posthog-react-native> The new RN SDK that uses the core as its base and adds new functionality as well as removing the dependency on native code (i.e. posthog-ios/android)ph-labelas well as not-tracking withph-no-captureuseLifecycleTracking> React hook to take care of correctly tracking events related to opening, backgrounding etc.useNavigationTracker> Automatic Screen tracking of routes when usingreact-navigation/nativewith controls for customising the screen name or properties trackedWhat is more of an experiment
/posthog-web> Actually moving theposthog-jsto this unified core is of course a massive undertaking. This is more of an example to show how it could work and to make sure the design of thecoreis not limiting a browser platform/posthog-node> This is more realistic that we could migrate over to a shared core but is not fully functioning. Most crucial would be handling the fact that this SDK will be used for multiple "users" rather than one persisted user. Nonetheless it shows high-potentialOutstanding TODOs
distinct_idis re-used. I started on this for iOS but an Android workaround would be needed and this would need some way of testing it worksposthog-nodeand its questionable how useful it is.Follow up